Skip to content

/ react-vis

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss Minimum supported versions of Node #1323

Open
Xiot opened this issue May 23, 2020 · 1 comment
Open

Discuss Minimum supported versions of Node #1323

Xiot opened this issue May 23, 2020 · 1 comment

Comments

@Xiot
Copy link
Contributor

@Xiot Xiot commented May 23, 2020 •
edited

Currently our CI tests run on Node 8 and 10.
The Node 8 tests were failing because the latest version of mkdirp (used by storybook-addon-jsx -> js-beautify) requires a minum of Node 10.

I've temporarily put in a resolution for js-beatify that keeps it pinned at a version that uses the old mkdirp.

If we remove the dependency on Node 8 we can remove this

react-vis/package.json

Lines 84 to 86 in fa32e96

"resolutions": {
"js-beautify": "1.10.3"
}

In terms of node versions, since the current LTS is @12 I think we can safely remove @8 from our CI, and probably add 12
@a-peltier a-peltier mentioned this issue May 29, 2020
Merged
@a-peltier
Copy link
Contributor

@a-peltier a-peltier commented May 29, 2020 •
edited

Agreed, I removed @8 in https://github.com/uber/react-vis/pull/1339.

Once it is merged I can make another PR to add @12 and remove the resolution field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Xiot @a-peltier
You can’t perform that action at this time.