Skip to content
#

baseline

Here are 124 public repositories matching this topic...

rjhornsby
rjhornsby commented Jan 9, 2017

As per this inline comment[1], there's a mismatch between the title/description and the actual test for systcl-17[2], martian logging.

The title says we're testing to ensure martian logging is disabled, but the actual test verifies that the logging is enabled. If I'm understanding correctly it's possible, even likely, that this is just a simple oversight in commit bb7c532f where the test

iamdanfox
iamdanfox commented Nov 14, 2019

What happened?

It's easy for people to write code like this with no failures:

} catch (InterruptedException e) {
  throw new RuntimeException(e);
}

Just rethrowing an exception like this is usually wrong because if the user is trying to abort, the calling thread will be unable to detect that an interruption happened and short-circuit.

What did you want to happen

Improve this page

Add a description, image, and links to the baseline topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the baseline topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.