Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_by_conversation 使用了 rtm v1 废弃的 `max_ts` 参数 #415

Open
weakish opened this issue Jul 23, 2019 · 0 comments
Open

find_by_conversation 使用了 rtm v1 废弃的 `max_ts` 参数 #415

weakish opened this issue Jul 23, 2019 · 0 comments
Labels

Comments

@weakish
Copy link
Member

@weakish weakish commented Jul 23, 2019

find_by_clientfind_all 也有同样的问题。

weakish added a commit to weakish/docs that referenced this issue Jul 23, 2019
Do not list `after_time` & `after_message_id` parametrs for methods:

- find_by_conversation
- find_by_client
- find_all

First, the parameters are wrong.
The parameters declared in SDK are actually
**before**_time & **before**_message_id.

Second, these parameters use deperated `max_ts` parameter of REST API.
See also leancloud/python-sdk#415
weakish added a commit to weakish/docs that referenced this issue Jul 23, 2019
Do not list `after_time` & `after_message_id` parametrs for methods:

- find_by_conversation
- find_by_client
- find_all

First, the parameters are wrong.
The parameters declared in SDK are actually
**before**_time & **before**_message_id.

Second, these parameters use deperated `max_ts` parameter of REST API.
See also leancloud/python-sdk#415
leeyeh added a commit to leancloud/docs that referenced this issue Jul 23, 2019
* fix(rtm): python guide wording

* feat(rtm): python guide basic example

Add a basic example in conversation overview section.

* fix(rtm): python guide wording

use 对话 instead of 会话 in section title for consistency

* fix(rtm): use table to list conv attrs in py guide

Use table to list conversation attributes in python guide.

* feat(rtm): python guide more features

For missing features of python sdk, use rest api directly.

* fix(rtm): correct & simplify py guide code sample

- fix module resolution issue
- simplify code

* feat(rtm): python guide rich media message

Describe how to send rich media message in python rtm guide.

* fix(rtm): remove `after_time` & `after_message_id`

Do not list `after_time` & `after_message_id` parametrs for methods:

- find_by_conversation
- find_by_client
- find_all

First, the parameters are wrong.
The parameters declared in SDK are actually
**before**_time & **before**_message_id.

Second, these parameters use deperated `max_ts` parameter of REST API.
See also leancloud/python-sdk#415

* fix(rtm): python guide message name typo

Fix a typo in message name:
find_by_client -> find_all

* fix(rtm): typo in python guide
@weakish weakish added the next label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.