Skip to content

/ generator-angular-fullstack

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user.controller.js:show seems to be dead code #2520

Open
nstuyvesant opened this issue Mar 19, 2017 · 2 comments
Open

user.controller.js:show seems to be dead code #2520

nstuyvesant opened this issue Mar 19, 2017 · 2 comments

Comments

@nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Mar 19, 2017

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.1.4
Node 7.7.3
npm 4.4.1
Operating System OS X 10
Item Answer
Transpiler Babel
Markup Pug
CSS SCSS
Router ui-router
Client Tests Mocha
DB Sequelize
Auth Y

If I scaffold out a project using the settings above, it seems that /server/api/user/user.controller.js:show is not used anywhere (GET /api/users/:id) other than the generated index.spec.js.

Instead, user.controller.js:me (GET /api/users/me) seems to be the only way a single user is retrieved.

I'm using Sequelize so perhaps this is in there for Mongoose only?

I might be overlooking something. Could someone else double-check this?
@Awk34
Copy link
Member

@Awk34 Awk34 commented Mar 19, 2017

Yes, it appears that it is not used anywhere
@nstuyvesant
Copy link
Contributor Author

@nstuyvesant nstuyvesant commented Mar 20, 2017

Thanks for verifying!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Awk34 @nstuyvesant
You can’t perform that action at this time.