Skip to content
#

stellar

Here are 281 public repositories matching this topic...

abuiles
abuiles commented Mar 25, 2020

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
All the files in src/ are using TS while the files in test are not. For consistency we should be using TS too in tests files, it will also let us dog food on our types.

A nice side effect of this is that we can start using modules in tests, that way we don't have to define in glo

msfeldstein
msfeldstein commented Oct 30, 2019

In classes like Address, its unclear what properties such as balances flags or most other fields actually contain. For example I'm not sure if balances is an array or a dict, and im not sure what properties the values inside of it contain. It's also unclear if inflation_destination is a public key string or an Address type.

Documentation should clarify what the shapes and types of all

msfeldstein
msfeldstein commented Aug 22, 2019

When dealing with amounts in stellar, you're dealing with them as a string. This can lead to difficulty checking equality (or comparison). There are many wrong was to do this such as
Float(str1) == Float(str2)
BigDecimal(str1).equals(BigDecimal(str2))
Other creatively wrong ways

It seems the right way is to use

public static boolean equalAmounts(String amount1, String amount2)
solar
andywer
andywer commented Mar 20, 2020

Create a view for setting the app password. Show it if there is no app password set yet (and feature flag for now!) right after the T&Cs screen.

Nice to have: Ask user about whether to enable biometric authentication in a second step if biometric auth is available. If so, perform biometric auth and update app launch auth policy.

Improve this page

Add a description, image, and links to the stellar topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the stellar topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.