Skip to content

/ openwhisk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Companion] Update feeds.md #4808

Open
wants to merge 1 commit into
base: master
from
Open

[Companion] Update feeds.md #4808

wants to merge 1 commit into from

Conversation

@steven0711dong
Copy link
Contributor

@steven0711dong steven0711dong commented Jan 29, 2020 •
edited

Description

when creating and updating a trigger with a feed, feed related parameters will require --feed-param flag.
This is a companion change for PR: apache/openwhisk-cli#479

DO NOT MERGE until apache/openwhisk-cli#479 gets merged. This PR should be merged quickly once apache/openwhisk-cli#479 gets merged :)

Related issue and scope

apache/openwhisk-cli#479

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.
@steven0711dong
Update feeds.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9975e97
@steven0711dong steven0711dong requested a review from rabbah Jan 29, 2020
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 29, 2020 •
edited

Codecov Report

Merging #4808 into master will decrease coverage by 6.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4808      +/-   ##
==========================================
- Coverage   85.21%   78.61%   -6.61%     
==========================================
  Files         197      197              
  Lines        8843     8843              
  Branches      606      606              
==========================================
- Hits         7536     6952     -584     
- Misses       1307     1891     +584
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0% <0%> (-100%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-96.23%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-93.85%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0% <0%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0% <0%> (-85.72%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0% <0%> (-77.78%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-74.08%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 7.69% <0%> (-50%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5868c6e...9975e97. Read the comment docs.
@dubee
dubee reviewed Feb 24, 2020
View changes
docs/feeds.md
@@ -67,7 +67,7 @@ When the user creates a trigger from the CLI with the **--feed** parameter, the

For example,assume the user has created a `mycloudant` binding for the `cloudant` package with their username and password as bound parameters. When the user issues the following command from the CLI:

`wsk trigger create T --feed mycloudant/changes -p dbName myTable`
`wsk trigger create T --feed mycloudant/changes --feed-param dbName myTable`

This comment has been minimized.

Sign in to view
@dubee

dubee Feb 24, 2020
Member

Is there doc showing that --feed-param and --trigger-param can be used in conjunction with each other?

This comment has been minimized.

Sign in to view
@dubee

dubee Feb 24, 2020
Member

It might be good to note that -p and -P only works for feed parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubee dubee

@rabbah rabbah

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaits-contributor blocked
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@steven0711dong @codecov-io @dubee @rabbah
You can’t perform that action at this time.