Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix example #2201
Open
fix example #2201
+5
−6
Conversation
| @@ -957,8 +957,7 @@ Other Style Guides | |||
| ```javascript | |||
| // bad | |||
| [1, 2, 3].map((number) => { | |||
| const nextNumber = number + 1; | |||
| `A string containing the ${nextNumber}.`; | |||
This comment has been minimized.
This comment has been minimized.
ljharb
Mar 24, 2020
Collaborator
this change would get rid of the entire point of showing this bad example.
This comment has been minimized.
This comment has been minimized.
roshal
Mar 26, 2020
•
Author
no it is not - returning a single expression in the function body violates the rule
this function is not valid without return
This comment has been minimized.
This comment has been minimized.
ljharb
Mar 28, 2020
Collaborator
That is the whole point - that it is an invalid example according to the guide (although it's perfectly valid javascript without the return). See the // bad above it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
roshal commentedMar 23, 2020
No description provided.