Skip to content
#

php-7

Here are 129 public repositories matching this topic...

hkdobrev
hkdobrev commented Feb 27, 2017

I don't think it is correct to generate code which will put an argument with a default value before an argument without a default value.

In the example the generated code produces a function like that:

function bar(int $a = null, string $b, bool $c, callable $d = null) : float

This means the first argument is optional, but the second and third aren't.

I realise = null i

nkkollaw
nkkollaw commented Aug 8, 2017

I'm wondering, does it really make sense to add documentation to our functions, if they're barely a wrapper to the original ones?

Unless there are gotchas, I would just leave:

/**
 * @link http://php.net/manual/en/function.xxx.php
 */

If we change something apart from the name of the function itself, we could just add a note:

/**
 * @link http://php.net/manual/en/

Improve this page

Add a description, image, and links to the php-7 topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the php-7 topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.