Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Option to disable terminator #216
Conversation
|
Thanks and sorry for the late reply. The resulting changes look good, though please see my review comments. After you update, please squash your commits into one so that there is only one commit, then force push. See e.g. https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git (and make sure that the resulting commit message only says "Add option to disable solar terminator" and not the old messages). |
| @@ -165,7 +165,7 @@ static void gtk_sat_map_init(GtkSatMap * satmap) | |||
| satmap->height = 0; | |||
| satmap->refresh = 0; | |||
| satmap->counter = 0; | |||
| satmap->show_terminator = FALSE; | |||
csete
May 16, 2020
Owner
I think the default should stay FALSE at least until the feature is complete and well tested.
I think the default should stay FALSE at least until the feature is complete and well tested.
| @@ -118,6 +118,7 @@ sat_cfg_bool_t sat_cfg_bool[SAT_CFG_BOOL_NUM] = { | |||
| {"GLOBAL", "MOD_WIN_POS", FALSE}, | |||
| {"GLOBAL", "MOD_STATE", FALSE}, | |||
| {"MODULES", "RULES_HINT", FALSE}, | |||
| {"MODULES", "MAP_SHOW_TERMINATOR", TRUE}, | |||
csete
May 16, 2020
Owner
Same as above, the default value should stay FALSE for now.
Same as above, the default value should stay FALSE for now.
| @@ -36,7 +36,7 @@ static GtkWidget *thumb; | |||
| static gchar *mapf = NULL; | |||
|
|
|||
| /* content selectors */ | |||
| static GtkWidget *qth, *next, *curs, *grid; | |||
| static GtkWidget *qth,*term, *next, *curs, *grid; | |||
csete
May 16, 2020
Owner
Missing space.
Missing space.
|
I followed the guide and tried squashing the commits, hope it is better now :) |
I am new to github, so please bare over with me. I read that i was supposed to rebase the changes and that is was i have tried to do. I am sorry for the messy commits, i accidentally addressed multiple things in the branch, and ad to clean it up.