Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HeatmapSeriesCanvas #1024

Open
wants to merge 2 commits into
base: master
from
Open

Conversation

@nbardy
Copy link

nbardy commented Oct 25, 2018

Implemented HeatMapSeriesCanvas renderer.

NOTE:

I can across a bug when swapping over to this using where when the data is updated the CanvasWrapper gets the old props for the first call and then the next update it will receive the new props. Seems to be a canvas wrapper bug, but I wasn't able to track it down yet.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2018

CLA assistant check
All committers have signed the CLA.

@mcnuttandrew mcnuttandrew self-assigned this Oct 26, 2018
@mcnuttandrew
Copy link
Collaborator

mcnuttandrew commented Oct 30, 2018

Hey @nbardy

This is an interesting idea! I like what you have so far. Would you mind adding a showcase example so that the differences can be checked? (see this file for example https://github.com/uber/react-vis/blob/master/showcase/plot/bar-chart.js) It can just be one of the old heatmap series examples but with a button to switch on and off from canvas mode.

I think we should address that canvas old props bug in another PR, mind filing an issue about it?

@mcnuttandrew
Copy link
Collaborator

mcnuttandrew commented Oct 30, 2018

Oh also, if you rebase the build will probably fix it self

@kobermeit
Copy link

kobermeit commented Jan 8, 2019

I was looking to see if I could implement heatmap on top of a candlestick chart but it looks like we can't yet in the live code. Is this feature likely to get merged in?

I'm trying to make my own heatmap (like bookmap.com, tensorcharts.com) where the heatmap is displayed in a candlestick chart, but I'm having trouble with it so far. Any demos or help here?

@mcnuttandrew
Copy link
Collaborator

mcnuttandrew commented Jan 8, 2019

@kobermeit I think you can probably do that with just the pure svg heatmap! That said if you are really dying to try out the canvas heatmap you can always copy the file used here copy the file and use it directly. Alternatively you can probably get away with just using the RectSeriesCanvas

@kobermeit
Copy link

kobermeit commented Jan 11, 2019

Thanks @mcnuttandrew , after experimenting with heatmap series in various chat libraries for a day, I decided it probably is best to do as you suggested - use an svg (or canvas) heatmap. What I'm struggling with now is getting the X Y coordinates of values in the candlestick chart so I can place the heatmap values in the correct spot (I'm trying to achieve something like tensorcharts, or bookmap.com). Is there a function I can use to get the coordinates by passing in the XY value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.