Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy_set_header to nginx template to fix redirection problem #581

Open
wants to merge 1 commit into
base: master
from

Conversation

@janissammetti
Copy link

@janissammetti janissammetti commented Oct 16, 2019

Without proxy_set_header there was a redirection from host:8443/admin to host:443/admin .
Therefore the admin page was not accessible.

Without proxy_set_header there was a redirection from host:8443/admin to host:443/admin .
@kspearrin
Copy link
Collaborator

@kspearrin kspearrin commented Oct 17, 2019

We already set the host header from our proxy.conf:

https://github.com/bitwarden/server/blob/master/util/Nginx/proxy.conf#L2

Should we just update that to include the port as well? Not sure how that might affect every endpoint though.

@janissammetti
Copy link
Author

@janissammetti janissammetti commented Oct 17, 2019

I was not sure about negative effects on other entpoints as well, therefore it was safer to just set the port for the admin entpoint. Maybe you can check if setting the port global does work fine ?

@Mart124
Copy link
Contributor

@Mart124 Mart124 commented Oct 17, 2019

mmmh strangely enough I also use an alternate port in my config.ymlfile :
https_port: 9443
And I do not face this redirection issue 😕

@kspearrin
Copy link
Collaborator

@kspearrin kspearrin commented Oct 17, 2019

I just tested this change and it breaks configs that are using 80/443. Trying to visit /admin is redirecting to https://domain.com:8443/admin/login?returnUrl=%2Fadmin

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 7, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.