Skip to content

/ server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create needed directories on Synology #757

Closed
wants to merge 1 commit into from
Closed

Create needed directories on Synology #757

wants to merge 1 commit into from

Conversation

@Mart124
Copy link
Contributor

@Mart124 Mart124 commented May 30, 2020

Hi,

This is a generic method to create missing directories on Synology.
Alternate method to #756 / #692.

Thx 👍
@Mart124
Create needed directories on Synology
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f6f9a55
@CLAassistant
Copy link

@CLAassistant CLAassistant commented May 30, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@Mart124 Mart124 mentioned this pull request May 30, 2020
Merged
@kspearrin kspearrin requested a review from mportune-bw May 30, 2020
@mportune-bw
mportune-bw reviewed Jun 1, 2020
View changes
Copy link
Contributor

@mportune-bw mportune-bw left a comment

While conceptually I like the idea of using docker-compose.yml as guidance for the directory names, this solution seems overly dependent on the exact formatting of that file. It also makes the assumption that only synology devices suffer from the missing dirs issue.
@Mart124
Copy link
Contributor Author

@Mart124 Mart124 commented Jun 1, 2020

this solution seems overly dependent on the exact formatting of that file

Yes, more or less, because this formatting is the same since the beginning, so I'm not sure we take a big risk here :)
We could be less dependant with the first grep changed like this :
grep "^ *- *../.*:/.*" docker-compose.yml
But I'm not sure this is really needed...

It also makes the assumption that only synology devices suffer from the missing dirs issue.

Sounds like that's the case ? And that one day their bug should be solved ?
We could in the future enlarge this condition if needed, we could also simply remove it if you prefer.

Anyway, thank you for your feedback, and feel free to close this PR if it's finally not worth it :)

Thank you 👍
@Mart124 Mart124 closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mportune-bw mportune-bw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Mart124 @CLAassistant @mportune-bw
You can’t perform that action at this time.