Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cert approval check to account for existing cert #752

Open
tj opened this issue Feb 1, 2019 · 0 comments
Open

Refactor cert approval check to account for existing cert #752

tj opened this issue Feb 1, 2019 · 0 comments
Labels
UX

Comments

@tj
Copy link
Member

@tj tj commented Feb 1, 2019

Currently if Up is waiting on a cert approval, and you C^, the next run will not output Check your email to approve the certificate, resulting in a up stack apply` attempting to use an unapproved certificate for the domain.

createCerts() uses some local state from RequestCertificate to see if we're waiting or not, it should just check pending certs instead to allow for both scenarios

@tj tj added the UX label Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.