Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: SHIRO-349 Security: Byte arrays (and other memory) holding sensitive … #36
Conversation
…data (even temporarily) should be zerod-out
eric-cho
changed the title
|
Hello @eric-cho This PR sounds interesting. Is this still WIP? Couldn't this be applied to 1.5.x or 1.6.x? |
|
Rebased: https://github.com/bmhm/shiro/tree/SHIRO-349 Contains breaking changes to CipherService and its Implementation JcaCipherService. Should have method signature change to "encrypt" as well. |
|
@bmhm, I missed this comment - It completed a long time ago, but there could some conflicts due to the source base is far from the latest version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Posting this PR as per Brian's comment.