Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAMQ-7052 - Fix JdbcXARecoveryBrokerTest and mLevelDBXARecoveryBrokerTest tests #298
Conversation
alanprot
force-pushed the
alanprot:activemq-5.15.x-Xa-rollback-tests
branch
2 times, most recently
from
62b3fb6
to
bc8706b
…est tests
alanprot
force-pushed the
alanprot:activemq-5.15.x-Xa-rollback-tests
branch
from
bc8706b
to
05a2526
|
Can you please rebase and fix conflict ? For the record, can you also please create the PR based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alanprot commentedSep 14, 2018
Fix the following tests:
JdbcXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332 expected:<0> but was:<4>
JdbcXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeCommitOnRestart:391 null
mKahaDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332 expected:<0> but was:<4>
mKahaDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeCommitOnRestart:391 null
mLevelDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332 expected:<0> but was:<4>
Those tests are failing because this feature (purge transactions after reboot) was only implemented on the KahaDBPersistenceAdapter.
Change that introduced this feature: ce7498c
The tests are failing because the class XARecoveryBrokerTest is used to test multiples adapters that are not implementing the same feature.
Steps to reproduce: