Skip to content

/ activemq

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a deprecated dependency ant:ant:1.6.2 #515

Open
wants to merge 1 commit into
base: master
from
Open

Removing a deprecated dependency ant:ant:1.6.2 #515

wants to merge 1 commit into from

Conversation

@sourabhsparkala
Copy link

sourabhsparkala commented Mar 23, 2020

  • Removing ant:ant:1.6.2 from org.apache.activemq:activemq-openwire-generator pom.xml

This fixes #AMQ-7448
@sourabhsparkala
Removing a deprecated dependency ant🐜1.6.2
b573e1f 
- Removing ant🐜1.6.2 from org.apache.activemq:activemq-openwire-generator pom.xml

This fixes #AMQ-7448
@jbonofre jbonofre self-requested a review Mar 23, 2020
@jbonofre
jbonofre requested changes Mar 23, 2020
View changes
Copy link
Member

jbonofre left a comment

<ant-version/> should be removed from the main parent pom.

And I think this dependency is required as the openwire-generator is used in activemq-client for the openwire-generate profile. I think it's require for the provided task. Let me check.
@sourabhsparkala
Copy link
Author

sourabhsparkala commented Mar 23, 2020 •
edited

<ant-version/> should be removed from the main parent pom.

And I think this dependency is required as the openwire-generator is used in activemq-client for the openwire-generate profile. I think it's require for the provided task. Let me check.

Hello @jbonofre, could you please confirm again if <ant-version> should be removed? I just removed an unwanted deprecated dependency.

Please let me know.

Thanks
Sourabh
@sourabhsparkala
Copy link
Author

sourabhsparkala commented Mar 31, 2020

@jbonofre requesting for an update.
@sourabhsparkala sourabhsparkala requested a review from jbonofre Aug 4, 2020
@sourabhsparkala
Copy link
Author

sourabhsparkala commented Aug 7, 2020

Hello @jbonofre. I confirmed the profile build of openwire-generate as instructed here in https://github.com/apache/activemq/blob/master/activemq-client/pom.xml#L301.

The old Ant dependency does not seem to be associated to any underlying modules as far as I could see.

Hence, it can be safely removed from activemq-openwire-generator
@sourabhsparkala
Copy link
Author

sourabhsparkala commented Aug 7, 2020

<ant-version/> holds the version for the latest Ant groupid. Could you please calrify again?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbonofre jbonofre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@sourabhsparkala @jbonofre
You can’t perform that action at this time.