Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Go modules and Dockerfile support #752
Open
Conversation
|
Hey @AngerM did you see my comment at #739 (comment) ?
Are we able to ignore those changes and move to upstream? Some of them seemed important. |
|
The only one that I noticed was the gcfg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Related issue: #739
This moves away from the vendored dependencies and switches to go modules, as well as adding a Dockerfile that contains the
gh-ostexecutable.The only side-effect was the
RelaxedParserModethat you guys had made changes for directly in your vendored version (as opposed to forking it). I dropped the one place that was used. If it's still desired, it would be best to fully fork the gcfg package and make the changes there.