Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Always set locale to english when running git #93
Conversation
|
@denian Can you review this? |
|
Thanks for your review! I never got an email with your review and also didn't see it when I asked you to review. Maybe it was only saved as a draft? Anyways, I fixed it now. ptal |
Ah, you're right. I had it as a draft. Sorry my bad :) Added a minor comment. Also, could you squash the commits into a single one? It works when we import the PR to our internal repo. Thanks! |
|
I'm sorry but I can't see your comment. |
Yannic
force-pushed the
Yannic:git_set_locale_to_english
branch
from
7d6dde5
to
228ed14
|
Thanks! Done & Squashed |
|
Thank you! I'll import this into our internal repo and afterwards the PR will be closed. Thanks! |
Copybara runs may fail if users use a different locale than english because we try to parse git's language dependent output. This change fixes this bug by forcing git's output language always to be english.
Yannic
force-pushed the
Yannic:git_set_locale_to_english
branch
from
228ed14
to
641a92d
|
@denian This somehow slipped through. Sorry for the extreme delay. Addressed all your comment now, ptal. //cc @jasonzhouu @mikelalcon |
|
Friendly ping? @hsudhof Can you help review this? |
Copybara runs may fail if users use a different locale than english
because we try to parse git's language dependent output.
This change fixes this bug by forcing git's output language always to be english.