Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds to python #2014

Open
wants to merge 1 commit into
base: master
from
Open

adds to python #2014

wants to merge 1 commit into from

Conversation

@Rahul-Rampal0804
Copy link

Rahul-Rampal0804 commented May 19, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Rahul-Rampal0804
adds to python
Loading status checks…
0a22938
@Rahul-Rampal0804
Copy link
Author

Rahul-Rampal0804 commented May 19, 2020

open cv
@cclauss
Copy link
Member

cclauss commented May 19, 2020 •
edited

Algorithms in this repo should not be how-to examples for existing Python packages. OpenCV is a Python package, not an algorithm. So, what is the algorithm in the pull request??? Please define a function as discussed at https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md#what-is-an-algorithm

Also: https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md
@itsvinayak
itsvinayak requested changes May 22, 2020
View changes
opencv.py
args = ap.parse_args()


def get_output_layers(net):

This comment has been minimized.

Sign in to view
Copy link
@itsvinayak

itsvinayak May 22, 2020

Member

provide details about the function and add doctest
opencv.py
return output_layers


def draw_prediction(img, class_id, confidence, x, y, x_plus_w, y_plus_h):

This comment has been minimized.

Sign in to view
Copy link
@itsvinayak

itsvinayak May 22, 2020

Member

provide details about the function and add doctest
opencv.py
@@ -0,0 +1,97 @@
import cv2

This comment has been minimized.

Sign in to view
Copy link
@itsvinayak

itsvinayak May 22, 2020

Member

examples and hints are needed
@cclauss
cclauss requested changes May 22, 2020
View changes
Copy link
Member

cclauss left a comment •
edited

Not yet an algorithm. Currently a how-to example. Not in a directory. Travis CI tests fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@itsvinayak itsvinayak

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
automated tests are failing
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Rahul-Rampal0804 @cclauss @itsvinayak
You can’t perform that action at this time.