Skip to content

/ material.angular.io

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-picker) fix theme picker bugs on mobile #496

Open
wants to merge 1 commit into
base: master
from
Open

fix(theme-picker) fix theme picker bugs on mobile #496

wants to merge 1 commit into from

Conversation

@philip-firstorder
Copy link

@philip-firstorder philip-firstorder commented Aug 2, 2018

Closes #495
@philip-firstorder
fix(theme-picker) fix theme picker bugs on mobile
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6ec4b4b 
Closes #495
@googlebot googlebot added the cla: yes label Aug 2, 2018
@Splaktar Splaktar self-assigned this May 20, 2020
@Splaktar
Copy link
Member

@Splaktar Splaktar commented May 20, 2020

Thank you for the contribution. This issue was resolved with our refactoring of the theme picker.
@Splaktar Splaktar closed this May 20, 2020
@philip-firstorder
Copy link
Author

@philip-firstorder philip-firstorder commented May 21, 2020

Thank you for the contribution. This issue was resolved with our refactoring of the theme picker.

I know my timeout hack is ugly, but now in your refactored theme picker you get the same problem again.

Just reproduced it on my iPhone7 https://material.angular.io/ v.9.2.4
@Splaktar Splaktar reopened this May 21, 2020
@Splaktar
Copy link
Member

@Splaktar Splaktar commented May 21, 2020

Please rebase. I'll try to reproduce this on an iPad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Splaktar Splaktar

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Theme picker bugs on mobile
3 participants
@philip-firstorder @Splaktar @googlebot
You can’t perform that action at this time.