Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
2,601 contributions in the last year
Contribution activity
June 2020
Created a pull request in sourcegraph/sourcegraph that received 4 comments
handlerutil: add test for checking `URLMovedError`
Adds a test case to test for URLMovedError when the requested repository name is "outdated". This is happens when a repository is renamed on code h…
+26
−0
•
4
comments
- authz: add integration test for GitHub permissions
- gqltest: rename e2e string literals
- authz: fix broken `ReposIDsWithOldestPerms` when repo is hard-deleted
- gqltest: stop using e2e for integration tests
- e2e: add search tests
- e2e: add tests for external service `repositoryPathPattern`
- authz: change PermsSyncer synced log to DEBUG
- authz: use GitHub database ID as bind ID
- authz: use `INT[]` to store permissions
- e2e: add tests for `auth.userOrgMap`
- e2e: add tests for organization settings cascade
- e2e: add tests for access token
- authz: use URN to identify provider to fetch permissions instead of ServiceID
- github: update VCR for `ListRepositoryCollaborators`
- authz: bypass private repos without authz provider configured for the code host
- test: use `-coverpkg=./...` to increase coverage
- authz: move permissions sidebaritem to enterprise
- authz: ignore 404 API error for GitHub
- usagestats: remove unused `GetSearchUsageStatistics`
- github: adds tests for `ListRepositoryCollaborators`
- graphqlbackend: add tests for external services
- db: add tests to external services
- gomod: use upstream grafana-tools/sdk
- gqltest: stop using e2e for integration tests
- codeintel: Search uploaded and indexes by repo name
- codeintel: Add local parameter to reference queries
- Document local certificate expiry
- repo-updater: remove updateScheduler mutex
- repo-updater: periodically bump priority of uncloned repositories
- repo-updater: dynamically update syncer update interval
- repo-updater: optimize computeNotClonedCount
- repo-updater: make syncer & scheduler aware of uncloned gitserver repositories
- Increase version context name limit
- campaigns: Cache external changeset diffstats
- Update src-expose serve docs
- Remove distinction between manual and automatic campaigns
- Reduce amount of commit resolvers created for file results
- git: refactor diff out of the GraphQL resolver
- codeintel: Enforce a max reset count on uploads and index records
- Add --except/--only to ./dev/start.sh
- search: merge line matches for union operation
- search: structural search uses literal search parser
- search: convert concat operator to spaces for literal search
- search: enable and/or operators in literal search
- search: add literal search parser for and/or operators
- search: pull labels out of parser
- search: expose search type to new parser
- Some pull request reviews not shown.
Created an issue in sourcegraph/sourcegraph that received 24 comments
Use Postgres intarray to store permissions `object_ids`
Context @mrnugget on Slack I have to say, I’m really not happy with the application-level joins we now have to do due to authz. Everytime we want …
24
comments
- Codecov: use go-acc for better code coverage on `master`
- authz: `ReposIDsWithOldestPerms` breaks when repos are hard-deleted from repo table
- Spike: Simplify `PermsStore` logic with intarray extension
- Spike: Pure SQL authz flow
- e2e: remove tests covered by `dev/gqltest`
- Add integration tests that saves rows to `user_external_accounts` then grant permissions
- gqltest: re-enable in CI on every branch
- gqltest: add dev docs
- Spike: Enforcing product tiers
- Docker `server:insiders` stops reporting current version
- `authzFilter` does not preserve the original order
- Ensure all API endpoints have appropriate rate limiting
- Ensure all API fields on the backend validate they are reasonable length
- Stop truncating microsecond everywhere with a util package