quic: remove redundant cast #34086
Closed
quic: remove redundant cast #34086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
Hmm... quick side note in that the |
jasnell
approved these changes
Jun 27, 2020
devnexen
approved these changes
Jun 27, 2020
MrHeer
approved these changes
Jun 30, 2020
jasnell
added a commit
that referenced
this issue
Jun 30, 2020
PR-URL: #34086 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
|
Landed in 68634d2 |
MylesBorins
added
the
backport-requested-v14.x
|
Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"? |
Yeap. |
targos
added
dont-land-on-v14.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes