Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add some support for running gh-ost in `MINIMAL` RBR setups #843
+76
−25
Conversation
Partially addresses #230. Add a new flag, `--switch-to-rbr-full`. If this flag is set, and `--assume-rbr` is **not** passed, gh-ost will first set binlog format to `ROW` if it is not already (this is existing behavior), but then _also_ sets the binlog row image to `FULL` if it is not already (this is the new behavior) before restarting replication. Mirroring the way gh-ost handles changing binary logging from SBR to RBR, gh-ost will _not_ reset the row image to `MINIMAL` under any circumstance.
ajm188
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Related issue: #230
Description
Adds some support for running gh-ost in
MINIMALRBR setupsPartially addresses #230.
Changes:
Add a new flag,
--switch-to-full-rbr. If this flag is set, and--assume-rbris not passed, gh-ost will first set binlog format toROWif it is not already (this is existing behavior), but then also sets the binlog row image toFULLif it is not already (this is the new behavior) before restarting replication.Mirroring the way gh-ost handles changing binary logging from SBR to RBR, gh-ost will not reset the row image to
MINIMALunder any circumstance.script/cibuildreturns with no formatting errors, build errors or unit test errors.