Skip to content

/ react-nodegui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with CMake on macOS (Catalina) #76

Closed
KirillSaltykov opened this issue Nov 27, 2019 · 8 comments
Closed

Error with CMake on macOS (Catalina) #76

KirillSaltykov opened this issue Nov 27, 2019 · 8 comments

Comments

@KirillSaltykov
Copy link

@KirillSaltykov KirillSaltykov commented Nov 27, 2019 •
edited

Describe the bug
When following steps on Getting started block, got an error with CMake.

To Reproduce
Steps to reproduce the behavior:

  1. Clone project from GitHub
  2. Go to project folder
  3. Run npm install
  4. See error

Expected behavior
Dependencies installed.

Screenshots

Desktop (please complete the following information):

  • OS: macOS
  • NodeGUI version: 0.6.7
  • React NodeGUI version: 0.2.6
  • OS Version: 10.15.1

Additional context
The problem is gone when install CMake using brew. I think to add install CMake requirement to Getting started page for not confusing people.
@a7ul
Copy link
Collaborator

@a7ul a7ul commented Nov 28, 2019

Hi @KirillSaltykov
The getting started page here: https://react.nodegui.org/docs/guides/getting-started/
mentions cmake as a requirement. Are we missing it somewhere ?
@KirillSaltykov
Copy link
Author

@KirillSaltykov KirillSaltykov commented Nov 28, 2019

Hi @master-atul
Yes, here: https://react.nodegui.org/#quick-start nothing about CMake 🙂
And when I tried to follow steps on this page, I got an error that CMake not found.
@a7ul
Copy link
Collaborator

@a7ul a7ul commented Nov 28, 2019

Ohh! okay. Thanks for pointing out!
@siowyisheng
Copy link

@siowyisheng siowyisheng commented Jan 17, 2020

On Windows I am also unable to succeed in the "Getting Started". I installed CMake but this fails with many errors.

cmake error

@nodegui/nodegui@0.12.1 build:addon: `cross-env CMAKE_BUILD_PARALLEL_LEVEL=8 cmake-js compile`
@a7ul
Copy link
Collaborator

@a7ul a7ul commented Jan 17, 2020 •
edited

Hi @siowyisheng Which version of Visual studio do you have installed ?
@siowyisheng
Copy link

@siowyisheng siowyisheng commented Jan 17, 2020

Vs 2017
@siowyisheng
Copy link

@siowyisheng siowyisheng commented Jan 17, 2020 •
edited

oops sorry I'm still on vs 2015. I'll upgrade and report back. My bad.

edit: It works now. Perhaps the quickstart have some footnote for the prerequisites.
@chrissantamaria
Copy link

@chrissantamaria chrissantamaria commented May 14, 2020

Agreed, the requirement should be noted on the quickstart page - just ran into this issue myself. I'm happy to make a pull request and add a brief requirement description if you'd like @master-atul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@a7ul @chrissantamaria @siowyisheng @KirillSaltykov
You can’t perform that action at this time.