Skip to content

/ generator-angular-fullstack

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings.html #2709

Open
wants to merge 1 commit into
base: master
from
Open

Update settings.html #2709

wants to merge 1 commit into from

Conversation

@JosephSKh
Copy link

@JosephSKh JosephSKh commented Apr 17, 2018

sending the form in changePassword function
@JosephSKh
Update settings.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
550c83c 
sending the form in changePassword function
@Awk34
Copy link
Member

@Awk34 Awk34 commented Apr 19, 2018

How about doing the same as the login and sign up pages? ex: https://github.com/angular-fullstack/generator-angular-fullstack/blob/master/templates/app/client/app/account(auth)/login/login.html#L9
@Awk34 Awk34 self-requested a review Apr 19, 2018
@Awk34 Awk34 added the V5 label Apr 19, 2018
@JosephSKh
Copy link
Author

@JosephSKh JosephSKh commented Apr 21, 2018

@Awk34 I think you've already done that? you are sending the form in the function, please point me if I'm wrong
@Awk34
Copy link
Member

@Awk34 Awk34 commented Apr 23, 2018

Take a look at this plunker: https://plnkr.co/edit/gmiLd1h7reY7XHLmbHgn?p=preview

Using this in the template sends the component instance, which is not what we want. Passing the ngForm instance is what we want, which includes data like valid, etc.
@Awk34
Awk34 requested changes Apr 23, 2018
View changes
Copy link
Member

@Awk34 Awk34 left a comment

add #settingsForm="ngForm" to the <form> tag, and replace this with settingsForm in the (ngSubmit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awk34 Awk34

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
V5
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@JosephSKh @Awk34
You can’t perform that action at this time.