doc: simplify and clarify ReferenceError material in errors.md #34151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
@nodejs/collaborators This could use some reviews. Sorry to ping widely but we don't have an errors group to ping... |
lpinca
approved these changes
Jul 3, 2020
antsmartian
approved these changes
Jul 3, 2020
cclauss
approved these changes
Jul 3, 2020
Flarna
approved these changes
Jul 3, 2020
legendecas
approved these changes
Jul 3, 2020
puzpuzpuz
approved these changes
Jul 3, 2020
|
Landed in dfeeb3c |
MylesBorins
added a commit
that referenced
this issue
Jul 14, 2020
"should always be considered" -> "indicate" PR-URL: #34151 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
MylesBorins
added a commit
that referenced
this issue
Jul 16, 2020
"should always be considered" -> "indicate" PR-URL: #34151 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
addaleax
added a commit
that referenced
this issue
Sep 22, 2020
"should always be considered" -> "indicate" PR-URL: #34151 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
"should always be considered" -> "indicate"
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes