what

• Document usage of stage parameter
• Explain why the term stage is used rather than environment

why

• Users may not be accustomed to the nomenclature due to commonly misused usage of the term stage

references

can you give me some idea why the term 'stage' was chosen over 'environment'? In the label module?

A "stage" is where software performs (e.g. runs)

Since you require Terraform 0.12.x, I think it's better to use the templatefile function instead.

...and you've got 100 stars 🎉

LoadBalancer coming blank in ElasticBeanstalk UI. Cannot see/list/edit options such as instanceport, https, routing, ssl certificates s3 log enabled etc. attached is the screenshot.

The module outputs the param codebuild_badge_url (as documented in the Outputs section of README) but seems like there is no input variable called badge_enabled. Seems like a simple fix and would be greatly appreciated if this could be added. Thanks

what

• Add example invocation

why

• We need this so we can soon enable automated continuous integration testing of module

Any of the action variables should default to [""] otherwise even if you set alb_groupd_alarms_enabled = false you will get errors about empty list of strings:

https://github.com/cloudposse/terraform-aws-ecs-web-app/blob/9d868399eaf3f7b1326ef9cda4fee505f9a292d3/variables.tf#L307-L407

Sorry don't have time right now to fix, test and pr.

Output hostname should be host_name to match both the naming convention of the other outputs AND the convention of the inputs.

The IAM policy for the role allows * too too many aws services without resource restrictions. Allowing a var supplied policy here could be a good first step. (https://github.com/cloudposse/terraform-aws-ecs-codepipeline/blame/master/main.tf#L66-L87).

Would be nice to have a working example of how to use this module with a fargate capacity provider
in awsvpc network mode