Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
1,631 contributions in the last year
Activity overview
Contributed to
observatorium/deployments,
thanos-io/thanos,
coreos/kube-prometheus
and 5 other
repositories
Contribution activity
July 2020
Created a pull request in coreos/prometheus-operator that received 2 comments
pkg/prometheus: Ensure relabeling of container label in ServiceMonitors
PodMonitors already default to relabeling namespace, pod and container into the target labels. ServiceMonitors should do the same to allow easy cor…
+31
−0
•
2
comments
- alerts: Fixed compactor alert to use correct aggregation function.
- reloader: Fixed test flakiness.
- receive: Track replications
- receive: Detach fanout context from request context
- ruler,receive,sidecar: StoreAPI Series encodes chunks to 120 samples instead of single, big one.
- receive: Fixed leak on receive and querier proxying Store API Series, which was leaking on errors.
- ci: Enable a set of linters to catch unused code
- storetestutil: Added shared series helpers on BucketSeries; added ProxySeries and MultiTSDB Series benchmarks.
- Query: Fix rendered JSON state value for rules and alerts should be in lowercase
- mixin: Increase ThanosReceiveNoUpload time check to 3h
- Update ThanosReceiveNoUpload to select sum == 0
- receive: Added more observability, fixed leaktest, to actually check leaks ):
Created an issue in google/cadvisor that received 3 comments
Problematic dimension handling of network metrics for host network pods/interfaces
Prometheus convention is that any sum over a metric's dimensions should make sense. Metrics exposed by cAdvisor violate this in multiple occurrence…
3
comments