build: recommend Python 3.8 to build on Windows #34182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
dont-land-on-v10.x
dont-land-on-v12.x
nodejs-github-bot
added
build
cclauss
reviewed
Jul 3, 2020
cclauss
reviewed
Jul 3, 2020
| @@ -526,7 +526,7 @@ to run it again before invoking `make -j4`. | |||
|
|
|||
| ##### Option 1: Manual install | |||
|
|
|||
| * [Python 2.7](https://www.python.org/downloads/) | |||
| * [Python 3.8](https://www.python.org/downloads/) | |||
There was a problem hiding this comment.
Why not https://www.microsoft.com/en-us/p/python-38/9mssztt1n39l ? It will prompt users as updates become available.
There was a problem hiding this comment.
I don't know if it's available on Windows 8
There was a problem hiding this comment.
I think no. The System Requirements on MS store said only for Windows10
Co-authored-by: Christian Clauss <cclauss@me.com>
lpinca
approved these changes
Jul 7, 2020
tniessen
approved these changes
Jul 9, 2020
jasnell
approved these changes
Jul 9, 2020
gengjiawen
approved these changes
Jul 10, 2020
targos
added a commit
that referenced
this issue
Jul 13, 2020
PR-URL: #34182 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
Landed in 913d36d |
MylesBorins
added a commit
that referenced
this issue
Jul 14, 2020
PR-URL: #34182 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
MylesBorins
added a commit
that referenced
this issue
Jul 16, 2020
PR-URL: #34182 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
@nodejs/python @nodejs/platform-windows