Skip to content
#

menus

Here are 127 public repositories matching this topic...

LukaszJaro
LukaszJaro commented May 14, 2019

Suggestion

WordPress core recently added this to the navwalker:
https://core.trac.wordpress.org/ticket/43290

Without adding these attributes google audit flags as a security risk, suggested change for class-wp-bootsrap-navwalker.php:

`//$atts['rel'] = ! empty( $item->xfn ) ? $item->xfn : '';

	if ( '_blank' === $item->target && empty( $item->xfn ) ) {
		$atts['rel'] = 'noopener 
ekazaev
ekazaev commented Apr 26, 2018

The problem is that this UIWindow stays in stack after Yoshi has been disappeared as Yoshi never removes this UIWindow from the stack and never makes main application's UIWindow keyAndVisible again. Yoshi just removes it reference to the UIWindow it created (see lines 100 and 111). It influences long term behaviour of the main application and also influences other libraries that creates UIWindow.

ababic
ababic commented Jul 13, 2019

Currently wagtailmenus makes a database query to identify the page IDs of ancestors, and keeps it around in the context to help figure this out.

If we can work this out without a query, we should definitely do so. And with active class derivation becoming more efficient, we should just go ahead and apply it every time, and not make it optional.

Arkitecht
Arkitecht commented Jul 12, 2015

There is documentation for adding attributes to menu items, but how about the menu parent element?
I tried doing a $menu->attribute, but that did not work.

I would like to add class names to the

    , I propose adding the same capabilities to menu as there are for item. IE:
    $menu = Menu::make(...)->attribute(['class'=>'navbar-nav','id'=>'main-nav'])
    would yield

Improve this page

Add a description, image, and links to the menus topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the menus topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.