Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix ConfigFile.Save() replacing symlink with file #2627
Merged
Conversation
|
@silvin-lubecki @cpuguy83 PTAL |
|
Ah, crap, looks like CircleCI disabled the "old" configs; |
thaJeztah
force-pushed the
thaJeztah:dont_overwrite_symlinks
branch
from
de62549
to
f716e43
|
LGTM |
In situations where `~/.docker/config.json` was a symlink, saving
the file would replace the symlink with a file, instead of updating
the target file location;
mkdir -p ~/.docker
touch ~/real-config.json
ln -s ~/real-config.json ~/.docker/config.json
ls -la ~/.docker/config.json
# lrwxrwxrwx 1 root root 22 Jun 23 12:34 /root/.docker/config.json -> /root/real-config.json
docker login
# Username: thajeztah
# Password:
# Login Succeeded
ls -la ~/.docker/config.json
-rw-r--r-- 1 root root 229 Jun 23 12:36 /root/.docker/config.json
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed the
thaJeztah:dont_overwrite_symlinks
branch
from
f716e43
to
75ab44a
|
Rebased to trigger CI |
Codecov Report
@@ Coverage Diff @@
## master #2627 +/- ##
=======================================
Coverage 58.12% 58.13%
=======================================
Files 295 295
Lines 21191 21194 +3
=======================================
+ Hits 12318 12321 +3
Misses 7966 7966
Partials 907 907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As noticed in #2595 (comment)
In situations where
~/.docker/config.jsonwas a symlink, saving the file would replace the symlink with a file, instead of updating the target file location;