Skip to content

/ cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03 backport] CircleCI updates #2629

Merged
merged 2 commits into from Jul 16, 2020
Merged

[19.03 backport] CircleCI updates #2629

merged 2 commits into from Jul 16, 2020

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 15, 2020

backports of:

  • #2563 CircleCI: update docker versions used in CI
  • #2628 Move circle.yml to .circleci/config.yml
thaJeztah added 2 commits Jun 3, 2020
@thaJeztah
CircleCI: update docker versions used in CI
Verified
This commit was signed with a verified signature.
thaJeztah Sebastiaan van Stijn
GPG key ID: 76698F39D527CE8C Learn about signing commits
d0b6560 
CircleCI now has 19.03; https://circleci.com/docs/2.0/building-docker-images/#docker-version

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 41255a4)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Move circle.yml to .circleci/config.yml
Verified
This commit was signed with a verified signature.
thaJeztah Sebastiaan van Stijn
GPG key ID: 76698F39D527CE8C Learn about signing commits
Loading status checks…
3d64a5d 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 77e78a2)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.13 milestone Jul 15, 2020
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #2629 into 19.03 will increase coverage by 0.27%.
The diff coverage is 57.55%.

@@            Coverage Diff             @@
##            19.03    #2629      +/-   ##
==========================================
+ Coverage   56.70%   56.97%   +0.27%     
==========================================
  Files         310      311       +1     
  Lines       21786    21886     +100     
==========================================
+ Hits        12354    12470     +116     
+ Misses       8519     8500      -19     
- Partials      913      916       +3
@thaJeztah thaJeztah marked this pull request as ready for review Jul 16, 2020
@thaJeztah
Copy link
Member Author

@thaJeztah thaJeztah commented Jul 16, 2020

Changes to master were merged; moved this out of draft
@tiborvass
tiborvass approved these changes Jul 16, 2020
View changes
@silvin-lubecki
silvin-lubecki approved these changes Jul 16, 2020
View changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

LGTM
@silvin-lubecki silvin-lubecki merged commit 1b96aa2 into docker:19.03 Jul 16, 2020
7 checks passed
7 checks passed
DCO DCO
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 57.55% of diff hit (target 50.00%)
Details
codecov/project 56.97% (+0.27%) compared to 5b63687
Details
@thaJeztah thaJeztah deleted the thaJeztah:19.03_backport_circleci_updates branch Jul 16, 2020
@thaJeztah thaJeztah mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborvass tiborvass

@silvin-lubecki silvin-lubecki

Assignees
No one assigned
Labels
area/testing status/2-code-review
Projects
None yet
Milestone
19.03.13
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@thaJeztah @codecov-commenter @tiborvass @silvin-lubecki
You can’t perform that action at this time.