Skip to content

/ ionic-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ion-popover after dismissal takes the focus to the top of the page (a11y) #21768

Closed
kensodemann opened this issue Jul 16, 2020 · 4 comments
Closed

bug: ion-popover after dismissal takes the focus to the top of the page (a11y) #21768

kensodemann opened this issue Jul 16, 2020 · 4 comments
Labels
package: core type: bug
Milestone
a11y

Comments

@kensodemann
Copy link
Member

@kensodemann kensodemann commented Jul 16, 2020

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
ion-popover after dismissal takes the focus to the top of the page. This creates issues during keyboard navigation. User have to bring back the focus to the place where left off.

Expected behavior:
After closing the popover, leave the focus wherever you were before hand.

Steps to reproduce:
A sample of the issue is reproduced in the repo:
https://github.com/mahiii85/ionic-test.git

Branch: review/ion-popover

The popovers are on the "!"

tab to A, B, or C
press enter to open the popover
press esc to close the popover

Each time you do this you end up starting over at the top of the page in your tabbing
@ionitron-bot ionitron-bot bot added the triage label Jul 16, 2020
@saivishnutammineni
Copy link

@saivishnutammineni saivishnutammineni commented Aug 12, 2020 •
edited

The issue exists with all types of overlays... alerts, popovers, full page loaders, etc which extend the overlay.
Once the overlay is removed from dom the focus is defaulted to body element.
@saivishnutammineni saivishnutammineni mentioned this issue Aug 12, 2020
Closed
@ionitron-bot ionitron-bot bot removed the triage label Aug 12, 2020
@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Sep 1, 2020

Created a simplified Codepen reproducing this behavior: https://codepen.io/brandyscarney/pen/bGpoNjR
@brandyscarney brandyscarney added this to the 5.3.3 milestone Sep 1, 2020
@liamdebeasi liamdebeasi modified the milestones: 5.3.3, 5.3.4 Sep 17, 2020
@liamdebeasi liamdebeasi mentioned this issue Sep 24, 2020
Merged
5 of 13 tasks
@liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Sep 24, 2020

Thanks for the issue. This has been resolved via #22167, and a fix will be available in an upcoming release of Ionic Framework.
liamdebeasi added a commit that referenced this issue Sep 24, 2020
@liamdebeasi
fix(overlays): return focus to presenting element after dismissal (#2…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
cc45ad8 
…2167)

resolves #21768
@brandyscarney brandyscarney modified the milestones: 5.3.4, a11y Oct 2, 2020
@ionitron-bot
Copy link

@ionitron-bot ionitron-bot bot commented Nov 1, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core type: bug
Projects
None yet
Milestone
a11y
Linked pull requests

Successfully merging a pull request may close this issue.

fix(overlays): return focus to presenting element after dismissal
4 participants
@kensodemann @liamdebeasi @brandyscarney @saivishnutammineni