NUTCH-2805: Rename plugin urlfilter-domainblacklist #540
Conversation
|
Hi @balashashanka, could you also add a note to CHANGES.txt which explains this as a breaking change (see for example the 1.16 release in the CHANGES.txt). |
| version="1.0.0" | ||
| provider-name="nutch.org"> | ||
|
|
||
| <runtime> | ||
| <library name="urlfilter-domainblacklist.jar"> | ||
| <library name="urlfilter-denyblacklist.jar"> |
sebastian-nagel
Jul 14, 2020
Contributor
Should be "urlfilter-domaindenylist.jar".
Should be "urlfilter-domaindenylist.jar".
balashashanka
Jul 14, 2020
Author
Contributor
Fixed this thanks....now git grep -F "domainblacklist" , just prints the CHANGES.txt since I included the changes to the plugin name and field name.
Fixed this thanks....now git grep -F "domainblacklist" , just prints the CHANGES.txt since I included the changes to the plugin name and field name.
added 2 commits
Jul 14, 2020
|
Thanks, @balashashanka! |
sebastian-nagel
added a commit
that referenced
this pull request
Aug 16, 2020
NUTCH-2805: Rename plugin urlfilter-domainblacklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As part of NUTCH-2802, the urlfilter-domainblacklist is renamed to "urlfilter-domaindenylist" and all the references and variables have been changed as well.