Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace override example #230

Conversation

@martindekov
Copy link
Contributor

@martindekov martindekov commented Jul 12, 2020

Adding namespace override to the examples when
there is dev in the stack.yml and during deployment
you override the namespace with the cli

Signed-off-by: Martin Dekov mvdekov@gmail.com

Description

Add namespace override to examples

Motivation and Context

  • I have raised an issue to propose this change (required)

Trello: https://trello.com/c/dIg2XqMJ/128-add-namespace-override-examples-to-docs

How Has This Been Tested?

This is document change, but I tested the scenario.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Example addition

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
Adding namespace override to the examples when
there is dev in the stack.yml and during deployment
you override the namespace with the cli

Signed-off-by: Martin Dekov <mvdekov@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

LGTM

@alexellis alexellis merged commit d218e79 into openfaas:master Jul 13, 2020
1 check passed
1 check passed
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.