Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify codes of playable area #8

Open
wants to merge 3 commits into
base: master
from
Open

Conversation

@sutara79
Copy link

@sutara79 sutara79 commented Aug 31, 2018

  • Unify indent.
  • Remove unnecessary space.
  • Not to display unnecessary scroll bar.

Example:

/* Before */
.wrapper {
  display: flex;
}

.wrapper input[type="text"] {
    flex: 1 1 auto;
  }


/* After*/
.wrapper {
  display: flex;
}

.wrapper input[type="text"] {
  flex: 1 1 auto;
}

I am localizing Typical use cases of Flexbox.
Live example's codes are hard to read.
So I beautified it.
Please merge.

sutara79 added 3 commits Aug 31, 2018
Unify indent.
Remove unnecessary space.
Not to display unnecessary scroll bar.
Not to display unnecessary scroll bar.
@sutara79
Copy link
Author

@sutara79 sutara79 commented Sep 3, 2018

I localized Backwards Compatibility of Flexbox in addition to above.
Then I noticed example's codes are hard to read.
Please consider to merge. (77e8883)

@avivmu
Copy link
Contributor

@avivmu avivmu commented Jul 22, 2020

@chrisdavidmills I suggest splitting this into two separate commits (I can do it if you will want) - formatting changes and visual changes.
The formatting could be trivially merged and the visual should be inspected to see if they add to the readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.