Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed utf-8 handling for text boxes #168

Merged
merged 1 commit into from Jun 25, 2020
Merged

fixed utf-8 handling for text boxes #168

merged 1 commit into from Jun 25, 2020

Conversation

@petiaccja
Copy link
Contributor

@petiaccja petiaccja commented Jun 25, 2020

No description provided.

@petiaccja
Copy link
Contributor Author

@petiaccja petiaccja commented Jun 25, 2020

I was wondering, though, wouldn't it be easier to just store all in-memory strings as an std::u32string? More memory, yes, but then there are no problems with the quirks of multi-byte characters.

@djowel
Copy link
Collaborator

@djowel djowel commented Jun 25, 2020

I was wondering, though, wouldn't it be easier to just store all in-memory strings as an std::u32string? More memory, yes, but then there are no problems with the quirks of multi-byte characters.

Gee, thanks! The artist port of the text layout management does indeed use u32 internally, most of the time. So perhaps that will be the likely outcome anyway. For now, let's keep it as it is.

@djowel djowel merged commit 585a454 into cycfi:develop Jun 25, 2020
3 checks passed
3 checks passed
Windows Latest MSVC
Details
Ubuntu Latest GCC
Details
macOS Latest Clang
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.