nornagon
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
1,860 contributions in the last year
Contribution activity
July 2020
Created a pull request in electron/electron that received 10 comments
refactor: mmap asar files
Description of Change In preparation for being able to load asar files from a dll/dylib, which are implicitly memory mapped. Checklist PR descrip…
+108
−113
•
10
comments
- refactor: ginify app
- refactor: ginify autoUpdater
- refactor: ginify Screen
- refactor: ginify SystemPreferences
- refactor: ginify InAppPurchase
- refactor: ginify NativeTheme
- refactor: ginify WebContents
- refactor: WebContents::From returns pointer
- refactor: use gin::Arguments in WebContents
- refactor: clean up Session with CleanedUpAtExit
- refactor: stop using isolate() in WebContents
- refactor: rename InspectableWebContents{Impl =>}
- chore: remove some unused code in the net module
- refactor: ginify NativeImage
- fix: coerce executeJavaScript arguments
- perf: do not convert object keys in ctx bridge as they are always primitives
- feat: add worldSafe flag for executeJS results
- fix: ensure that errors thrown in the context bridge are created in the correct context
- build: free up more space on the mac VM
- build: add apple silicon support
- perf: pass primitives directly through the context bridge, avoids copying
- build: ensure that electron/lib/browser can only use browser or common imports
- build: tsify asar and move to webpack js2c pipeline
- build: run the JS linter on the build folder
- fix: use try/catch for base class converter error
- build: build squirrel and its dependencies from source
- feat: MessagePorts in the main process
- feat: expose sessionId in debugger module
- chore: use node_bindings loop for clarity
- fix: use RenderViewReady to call InstallTransparency
Created an issue in electron/electron that received 1 comment
double-free of WebContents when using <webview>
I think this is a race condition between V8 garbage collection and the normal destruction of the WebContents. Possibly related to #24344? I can fai…
1
comment