Skip to content

/ mmctl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-25647] add user delete command #174

Merged
merged 9 commits into from Jul 31, 2020
Merged

[MM-25647] add user delete command #174

merged 9 commits into from Jul 31, 2020

Conversation

@ashishbhate
Copy link
Member

ashishbhate commented Jul 8, 2020

Summary

  • Add user delete command
  • Update server dependency for server side support for user delete

Ticket Link
ashishbhate added 3 commits Jul 8, 2020
@ashishbhate
command to delete users
685d946
@ashishbhate
docs for command to delete users
eba814d
@ashishbhate
update server dependency version for user delete
Loading status checks…
bf65215
@ashishbhate ashishbhate requested review from mgdelacroix and ethervoid Jul 8, 2020
@ashishbhate
Copy link
Member Author

ashishbhate commented Jul 8, 2020

This PR is blocked by mattermost/mattermost-server#14944

For now I've pointed the server dependency to the PR commit. After the PR is merged I'll update to the merge commit.
@ashishbhate
ashishbhate reviewed Jul 8, 2020
View changes
commands/user.go
if err := getUserDeleteConfirmation(); err != nil {
return err
}
Comment on lines +390 to +392

This comment has been minimized.

Sign in to view
@ashishbhate

ashishbhate Jul 8, 2020

Author Member

I did this because dupl complains that this function is too similar to deleteTeamsCmdF
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020 •
edited

Codecov Report

Merging #174 into master will increase coverage by 0.18%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   67.29%   67.48%   +0.18%     
==========================================
  Files          33       33              
  Lines        2547     2577      +30     
==========================================
+ Hits         1714     1739      +25     
- Misses        771      776       +5     
  Partials       62       62
Impacted Files Coverage Δ
commands/user.go 84.48% <83.33%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ae704...590c925. Read the comment docs.
@ashishbhate
fix test name
Loading status checks…
09ce633
@ethervoid
ethervoid reviewed Jul 8, 2020
View changes
Copy link
Member

ethervoid left a comment

LGTM, some test addition
commands/user_test.go Show resolved Hide resolved
@ashishbhate
improve coverage
Loading status checks…
34ab42b
@ashishbhate ashishbhate requested a review from ethervoid Jul 13, 2020
@ethervoid
ethervoid approved these changes Jul 13, 2020
View changes
@mgdelacroix
mgdelacroix approved these changes Jul 13, 2020
View changes
Copy link
Member

mgdelacroix left a comment

LGTM! 👍 a couple of non-blocking nits added
commands/user.go Outdated Show resolved Hide resolved
commands/user.go Outdated Show resolved Hide resolved
@mgdelacroix mgdelacroix requested a review from ogi-m Jul 13, 2020
ashishbhate added 3 commits Jul 14, 2020
@ashishbhate
fix help text
Loading status checks…
5ee9da6
@ashishbhate
Merge branch 'master' into MM-25647-user-delete
Loading status checks…
986eb20
@ashishbhate
update docs
Loading status checks…
e8a3fa6
@ogi-m
ogi-m approved these changes Jul 15, 2020
View changes
Copy link
Member

ogi-m left a comment

QA will test post-merge
@ashishbhate
Copy link
Member Author

ashishbhate commented Jul 24, 2020

Since this has been bumped to 5.28 on the server, lets wait for #182 to merge this.
@ashishbhate
Merge branch 'master' into MM-25647-user-delete
Loading status checks…
590c925
@ashishbhate ashishbhate added this to the v5.28 milestone Jul 31, 2020
@ashishbhate ashishbhate merged commit 7b40a66 into master Jul 31, 2020
5 checks passed
5 checks passed
cla/mattermost ashishbhate authorized
Details
codecov/patch 83.33% of diff hit (target 67.29%)
Details
codecov/project 67.48% (+0.18%) compared to 12ae704
Details
merge/blocked Merged allowed
Details
untagged-build Workflow: untagged-build
Details
@ashishbhate ashishbhate deleted the MM-25647-user-delete branch Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgdelacroix mgdelacroix

@ethervoid ethervoid

@ogi-m ogi-m

Assignees
No one assigned
Labels
4: Reviews Complete
Projects
None yet
Milestone
v5.28
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@ashishbhate @codecov-commenter @mgdelacroix @ethervoid @ogi-m
You can’t perform that action at this time.