Skip to content

/ dom-testing-library

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in wait-for test #688

Merged
merged 1 commit into from Jul 10, 2020
Merged

Fixed typo in wait-for test #688

merged 1 commit into from Jul 10, 2020

Conversation

@keiya01
Copy link
Contributor

keiya01 commented Jul 10, 2020

What:

I fixed typo in wait-for test.

Why:

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged
@keiya01
fixed typo
Loading status checks…
5ca7f72
@codesandbox
Copy link

codesandbox bot commented Jul 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5ca7f72:

Sandbox Source
kentcdodds/react-testing-library-examples Configuration
@codecov
Copy link

codecov bot commented Jul 10, 2020 •
edited

Codecov Report

Merging #688 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #688   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          603       603           
  Branches       151       151           
=========================================
  Hits           603       603

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae9244...5ca7f72. Read the comment docs.
@kentcdodds
kentcdodds approved these changes Jul 10, 2020
View changes
Copy link
Member

kentcdodds left a comment

Thanks!
@kentcdodds kentcdodds merged commit ca9adde into testing-library:master Jul 10, 2020
4 checks passed
4 checks passed
ci/codesandbox Building packages succeeded.
Details
codecov/patch Coverage not affected when comparing 9ae9244...5ca7f72
Details
codecov/project 100.00% (+0.00%) compared to 9ae9244
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kentcdodds
Copy link
Member

kentcdodds commented Jul 10, 2020

@all-contributors please add @keiya01 for docs
@allcontributors allcontributors bot mentioned this pull request Jul 10, 2020
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Jul 10, 2020

@kentcdodds

I've put up a pull request to add @keiya01! 🎉
@kentcdodds
Copy link
Member

kentcdodds commented Jul 12, 2020

🎉 This PR is included in version 7.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀
@kentcdodds kentcdodds added the released label Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@keiya01 @kentcdodds
You can’t perform that action at this time.