Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure code found by DeepCode #1443

Open
patlecat opened this issue Jun 6, 2020 · 0 comments
Open

Insecure code found by DeepCode #1443

patlecat opened this issue Jun 6, 2020 · 0 comments

Comments

@patlecat
Copy link

@patlecat patlecat commented Jun 6, 2020

Running deepcode on the lib it has found a few insecure parts in the code (DeepCode):

Unsanitized input flows from data from a remote resource and is used to dynamically construct the HTML page on client side in 0. This may result in a DOM Based Cross-Site Scripting attack (DOMXSS).
Problem description

SHA1 (used in EVP_sha1) is insecure. Consider changing it to a secure hashing algorithm (e.g. SHA256).
Problem description

Content-type text/html set in setRequestHeader does not specify a charset. Add charset=utf-8 or another charset.
Problem description

Container std::vector is only updated but does not seem to be ever queried.
Problem description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.