Skip to content

/ core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-6062 Added verbose logging of why promises are not actuated (3.15.x) #4245

Open
wants to merge 6 commits into
base: 3.15.x
from
Open

ENT-6062 Added verbose logging of why promises are not actuated (3.15.x) #4245

wants to merge 6 commits into from

Conversation

@craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Jun 26, 2020

Ticket: ENT-6062
Changelog: Title
@craigcomstock
wip, to generate a build for customer
Unverified
The key that signed this is expired.
GPG key ID: 9F8C5563AABCE30A Learn about signing commits
Loading status checks…
e535b39 
(cherry picked from commit e176fc9)
@craigcomstock
Copy link
Contributor Author

@craigcomstock craigcomstock commented Jun 26, 2020

@cf-bottom jenkins please
@cf-bottom
Copy link

@cf-bottom cf-bottom commented Jun 26, 2020

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5311/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5311/
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jun 26, 2020

This pull request introduces 6 alerts when merging e535b39 into e368657 - view on LGTM.com

new alerts:

  • 6 for Pointer argument is dereferenced without checking for NULL
@craigcomstock craigcomstock changed the title ENT-6062 Added verbose logging of why promises are not actuated ENT-6062 Added verbose logging of why promises are not actuated (3.15.x) Jun 26, 2020
@craigcomstock
Copy link
Contributor Author

@craigcomstock craigcomstock commented Jun 26, 2020

This pull request introduces 6 alerts when merging e535b39 into e368657 - view on LGTM.com

new alerts:

* 6 for Pointer argument is dereferenced without checking for NULL

Yes. I was thinking about that one. ;) Thank you.
@craigcomstock
sq/wip, changed ExpandPromise() to ALWAYS expand promises so that rep…
Unverified
The key that signed this is expired.
GPG key ID: 9F8C5563AABCE30A Learn about signing commits
Loading status checks…
5094f86 
…ort_level is available to change logging level, might be less efficient but suits the needs of this debugging exercise
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jun 29, 2020

This pull request introduces 16 alerts and fixes 1 when merging 5094f86 into e368657 - view on LGTM.com

new alerts:

  • 10 for Commented-out code
  • 6 for Pointer argument is dereferenced without checking for NULL

fixed alerts:

  • 1 for Pointer argument is dereferenced without checking for NULL
@craigcomstock
fixup for ifvarclass, look at i script for how to compile with PRIVAT…
Unverified
The key that signed this is expired.
GPG key ID: 9F8C5563AABCE30A Learn about signing commits
Loading status checks…
81602b4 
…E_DEBUG for debugging
@craigcomstock
Copy link
Contributor Author

@craigcomstock craigcomstock commented Jun 29, 2020

@cf-bottom jenkins please :)
@cf-bottom
Copy link

@cf-bottom cf-bottom commented Jun 29, 2020

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5316/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5316/
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jun 29, 2020

This pull request introduces 6 alerts when merging 81602b4 into e368657 - view on LGTM.com

new alerts:

  • 6 for Pointer argument is dereferenced without checking for NULL
@craigcomstock
fix memory leak, squash me
Unverified
The key that signed this is expired.
GPG key ID: 9F8C5563AABCE30A Learn about signing commits
Loading status checks…
f458d0b
@craigcomstock
Copy link
Contributor Author

@craigcomstock craigcomstock commented Jun 29, 2020

@cf-bottom jenkins again please, valgrind should be OK now.
@cf-bottom
Copy link

@cf-bottom cf-bottom commented Jun 29, 2020

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5317/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5317/
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jun 29, 2020

This pull request introduces 6 alerts when merging f458d0b into e368657 - view on LGTM.com

new alerts:

  • 6 for Pointer argument is dereferenced without checking for NULL
@nickanderson
Copy link
Member

@nickanderson nickanderson commented Jun 30, 2020

@cf-bottom jenkins, with exotics, please
@cf-bottom
Copy link

@cf-bottom cf-bottom commented Jun 30, 2020

Alright, I triggered a build:

Build Status

(with exotics)

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5319/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5319/
@craigcomstock
wip, get variable value information to debug skipping
Unverified
The key that signed this is expired.
GPG key ID: 9F8C5563AABCE30A Learn about signing commits
f275f23
@craigcomstock
cleanup
Unverified
The key that signed this is expired.
GPG key ID: 9F8C5563AABCE30A Learn about signing commits
Loading status checks…
b397c0e
@craigcomstock
Copy link
Contributor Author

@craigcomstock craigcomstock commented Jul 1, 2020

@cf-bottom jenkins with exotics
@cf-bottom
Copy link

@cf-bottom cf-bottom commented Jul 1, 2020

Sure, I triggered a build:

Build Status

(with exotics)

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5324/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5324/
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jul 1, 2020

This pull request introduces 9 alerts when merging b397c0e into e368657 - view on LGTM.com

new alerts:

  • 7 for Pointer argument is dereferenced without checking for NULL
  • 2 for Commented-out code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP invalid
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@craigcomstock @cf-bottom @nickanderson
You can’t perform that action at this time.