Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a __len__() function to doubly_linked_list.py #2042

Open
wants to merge 25 commits into
base: master
from
Open

Add a __len__() function to doubly_linked_list.py #2042

wants to merge 25 commits into from

Conversation

@Lakshmikanth2001
Copy link
Contributor

Lakshmikanth2001 commented May 28, 2020 •
edited by cclauss

Blocked by #2052

Describe your change:

in linked list class constructor i have added a data member called size and a function call length

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Lakshmikanth2001
Update __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
1cd0e54 
please add a function to get length of linked list
@Lakshmikanth2001
Update __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
21d7333
@Lakshmikanth2001
Update doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
dc0c694 
all size function lo doubly linked list class
@Lakshmikanth2001
Merge pull request #2 from Lakshmikanth2001/Lakshmikanth2001-patch-2
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6938c58 
Update doubly_linked_list.py
@Lakshmikanth2001
Merge pull request #1 from Lakshmikanth2001/Lakshmikanth2001-patch-1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
5300746 
Update __init__.py
@Lakshmikanth2001
prime number _better method
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6a19daf
@Lakshmikanth2001
comments
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
bcafc11
@cclauss
cclauss reviewed May 28, 2020
View changes
data_structures/linked_list/__init__.py Outdated Show resolved Hide resolved
@cclauss
cclauss requested changes May 28, 2020
View changes
Copy link
Member

cclauss left a comment

Please undo the maths/prime_check.py change and move that to a separate pull request as discussed in CONTRIBUTING.md.
@Lakshmikanth2001
Updated init.py 2
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f110e49 
made it more pythonic
@Lakshmikanth2001
updated length function
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
bc75424
@cclauss
Add doctests to LinkedList().__len__()
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ffb58d2
@TheAlgorithms TheAlgorithms deleted a comment from onlinejudge95 May 31, 2020
cclauss added 4 commits May 31, 2020
@cclauss
Add doctests to LinkedList().__len__()
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
df7a07c
@cclauss
Revert changes to prime_check.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
da43761
@cclauss
Revert changes to prime_check.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6d549a3
@cclauss
Merge branch 'master' into master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
22cc5d2
@github-actions github-actions bot force-pushed the Lakshmikanth2001:master branch from 43b3db5 to 22cc5d2 May 31, 2020
cclauss added 6 commits May 31, 2020
@cclauss
Update doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
911dde9
@cclauss
Update doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
639d77b
@cclauss
Update doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0587999
@cclauss
Update doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
81b3a68
@cclauss
Update doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dbb57e9
@cclauss
Update doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1d6b37e
github-actions and others added 4 commits May 31, 2020
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
b1967c5
@cclauss
Update doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8285c08
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
dc86f40
@cclauss
self.is_empty()
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
54e661b
@cclauss
cclauss requested changes May 31, 2020
View changes
Copy link
Member

cclauss left a comment

Blocked by #2052
@cclauss
Revert all changes to __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
93b0652
@cclauss cclauss changed the title adding size function to linkedlist data_strucuture Add a __len__() function to doubly_linked_list.py Jun 1, 2020
@cclauss
Copy link
Member

cclauss commented Jun 1, 2020

@Lakshmikanth2001 Thanks for this pull request because it found a flaw in doubly_linked_list.py. It would be great is you could fix that algorithm so that the tests in #2052 pass. If not, I will try to fix that at the end of this week. Thanks again.
@stale
Copy link

stale bot commented Jul 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the wontfix label Jul 1, 2020
@cclauss cclauss removed the wontfix label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Lakshmikanth2001 @cclauss
You can’t perform that action at this time.