Skip to content

/ express

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate `maxAge` appropriateness before use #3936

Open
wants to merge 1 commit into
base: master
from
Open

Validate `maxAge` appropriateness before use #3936

wants to merge 1 commit into from

Conversation

@cjbarth
Copy link

@cjbarth cjbarth commented Apr 18, 2019

Addresses issue #3935 .
@cjbarth
Validate `maxAge` appropriateness before use
Loading status checks…
7d51ea9
@cjbarth cjbarth force-pushed the cjbarth:master branch from 899cb56 to 7d51ea9 Apr 18, 2019
@cjbarth
Copy link
Author

@cjbarth cjbarth commented Apr 18, 2019

@dougwilson I've added tests.
@dougwilson dougwilson removed the needs tests label Apr 18, 2019
@dougwilson
Copy link
Member

@dougwilson dougwilson commented Apr 18, 2019

Thanks. The conversation in the issue needs to be resolved first so we know what the appropriate fix is. Then I will review the PR once that is known 👍
@dougwilson
dougwilson requested changes Apr 18, 2019
View changes
Copy link
Member

@dougwilson dougwilson left a comment

Please add Node.js 0.10 compatibility.
@cjbarth
Copy link
Author

@cjbarth cjbarth commented Apr 18, 2019

I'll do so once we officially decide how we'd like to handle this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pr
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cjbarth @dougwilson
You can’t perform that action at this time.