Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign upHighlights
- Arctic Code Vault Contributor
- Pro
Pinned
2,430 contributions in the last year
Activity overview
Contributed to
sourcegraph/sourcegraph,
DefinitelyTyped/DefinitelyTyped,
felixfbecker/olfaction
and 5 other
repositories
Contribution activity
July 2020
- felixfbecker/chromatic-cli JavaScript
Created a pull request in sourcegraph/sourcegraph that received 12 comments
Use Dart Sass
sass-loader recommends using Dart Sass, which has become the official Sass implementation, as opposed to node-sass (libsass).
No Node native addon…
+30
−182
•
12
comments
- Update info color to a lighter cyan
- Extend global styles storybook
- Badge design
- Import * as H from 'history'
- Automatically accept Chromatic baseline on master
- Integration test improvements
- Add integration tests for spaces in paths
- Add Figma integration to Storybook
- Integration test docs
- Disable animation in story
- Auto-retry Chromatic step in CI
- Upload storybook to Chromatic
- Increase contrast of placeholders to meet WCAG
- Rename e2e-* selectors to test-*
- Add integration tests for extensions (blocked)
- Fix Bitbucket file path wrapping
- Use mocha directly for integration tests and move to shared/
- Integration test updates
- Add integration tests to CI
- Serve mock index.html and window.context
- Update logo
- Override GraphQL API for integration tests
- Include .collapse CSS class for Cookiebot
- Refactor remaining extension host APIs
- Add platform to code host integration event logs
- Storybook additions 2
- Fix browser extension broken links when branch is specified
- Web content styles
- remove replacer
- Log click events on search homepage and repogroup page
- Fix private repository detection on GitHub.com
- Fix: low contrast search examples in dark theme
- Storybook additions
- Fix monaco in storybooks
- Fix schema file watcher
- add public code tag line
- ci: use nvmrc version to set up node
- Fix flacky chromatic snapshots
- Add private code CTAs
- migrated to using graphQL codegen + made all fragment have unique names
- Add integration tests
- Remove todo-security.sh check
- Add Figma URL for UserNavItem
- ci: run shared tests sooner
- Update dependency mocha to v8
- Onboarding regression test fixes
- Update dependency puppeteer to v5
- Update polly to v5 (major)
- dev: only support watchman
- Some pull request reviews not shown.
Created an issue in sourcegraph/sourcegraph that received 10 comments
Replace forked ts-graphql-plugin-based type query generator
For integration tests, we currently use a mostly-copy-pasted adapted version of ts-graphql-plugin: https://github.com/sourcegraph/sourcegraph/blob/…
10
comments
- Make license check not fail when our node version is upgraded
- CSS/Sass/SCSS basic code intelligence
- Add integration tests for extension functionality (get Puppeteer to intercept web worker requests)
- Add percy snapshots to integration tests
- Add integration tests for browser extension
- Change .e2e selectors to something that also applies to other test types
- Write proper integration test docs/handbook page
- No TypeScript hover from LSIF in our repo (but shows hover in VS Code)
- Repogroup homepage Percy snapshots are flaky because cursor is blinking
- Use Chromatic to host our Storybook
- sourcegraph.com shows global warning banner "Unable to fetch alerts status: status 404"
- Kubernetes repogroup icon is not transparent, looks bad in dark theme
- Border-radius wrong in repogroup page search query input groups
- Fancy quotes on repogroup pages
- TypeScript hover shows type any