Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDeprecation message for SequenceNode and FallbackNode #158
Conversation
miccol
changed the title
|
I am going to have a more "radical" proposal. What if we add a parameter (input port) to Sequence and Fallback) with a boolean "isReactive"? |
|
or the boolean "isLatched"? I think the word "reactive" may not be intuitive for some BT users |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR addresses issue #75 . It is not a breaking change as the SequenceNode and FallbackNode are still there. The nodes with memory are named
LatchedSequenceandLatchedFallback(to be consistent withReactiveSequenceandReactiveFallback)