Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 40 million developers.
Sign up
- San Francisco, CA
- http://www.linkedin.com/in/bmish
Pinned
233 contributions in the last year
Activity overview
Contributed to
ember-cli/eslint-plugin-ember,
ember-template-lint/ember-template-lint,
eslint/eslint
and 3 other
repositories
Contribution activity
August 2019
Created a pull request in ember-cli/eslint-plugin-ember that received 5 comments
Add new rule `require-computed-property-dependencies`
This rule detects and autofixes computed properties with missing dependencies that look like:
this.get('property')
this.property (ES5 getter)
this…
+1,043
−50
•
5
comments
- Add `allowDynamicKeys` option (default true) to `require-computed-property-dependencies` rule
- Improve handling of nested keys inside braces for `require-computed-property-dependencies` rule
- Improve detection of missing dependencies in `require-computed-property-dependencies` rule
- WIP: Add multidep for running tests with multiple versions of eslint (DO NOT MERGE)
- Fix eslint 6 rule test parser error
- Add tests that rules are setup correctly (not missing tests, docs, exports, etc)
- Add new rule `require-await-function-call`
- Add null check in `new-module-imports` rule (again)
- Add new `no-arrow-function-computed-properties` rule
- Upgrade from eslint 4 to 5 (internal-only)
- Update exporting of rule error messages to rule tests for consistency and for eslint 5 support
- Add new `no-incorrect-calls-with-inline-anonymous-functions` rule
- Refactor null checks for `new-module-imports` and `use-ember-data-rfc-395-imports` rules
- Fix false positives for import statements with `use-ember-data-rfc-395-imports` rule
- Add null check in `new-module-imports` rule
- Add new `use-ember-data-rfc-395-imports` rule