Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tropospheric NO2 Monitoring using Sentinel-5P over Wuhan #699

Closed
wants to merge 2 commits into from

Conversation

@shivanip32
Copy link
Contributor

shivanip32 commented May 19, 2020

Tropospheric NO2 Monitoring using Sentinel-5P over Wuhan

Checklist

Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.

  • All imports are in the first cell? First block of imports are standard libraries, second block are 3rd party libraries, third block are all arcgis imports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.
  • All GIS object instantiations are one of the following?
    • gis = GIS()
    • gis = GIS('https://www.arcgis.com', 'arcgis_python', 'P@ssword123')
    • gis = GIS(profile="your_online_profile")
    • gis = GIS('https://pythonapi.playground.esri.com/portal', 'arcgis_python', 'amazing_arcgis_123')
    • gis = GIS(profile="your_enterprise_portal")
  • If this notebook requires setup or teardown, did you add the appropriate code to ./misc/setup.py and/or ./misc/teardown.py?
  • If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with the api_data_owner user?
  • Code refactored & split out across multiple cells, useful comments?
  • Consistent voice/tense/narrative style? Thoroughly checked for typos?
  • All images used like <img src="base64str_here"> instead of <img src="https://some.url">? All map widgets contain a static image preview? (Call mapview_inst.take_screenshot() to do so)
  • All file paths are constructed in an OS-agnostic fashion with os.path.join()? (Instead of r"\foo\bar", os.path.join(os.path.sep, "foo", "bar"), etc.)
  • IF YOU WANT THIS SAMPLE TO BE DISPLAYED ON THE DEVELOPERS.ARCGIS.COM WEBSITE, ping @ DavidJVitale so he can add it to the list for the next deploy
@review-notebook-app
Copy link

review-notebook-app bot commented May 19, 2020

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

Shivani Pathak
@priyankatuteja priyankatuteja requested a review from moonlanderr May 21, 2020
@AtmaMani
Copy link
Member

AtmaMani commented May 27, 2020

@shivanip32 @priyankatuteja @moonlanderr hold off on reviewing this sample. There is a way programmatically search and download 5P data using sentinelsat library and there is a way to convert netCDF to Raster layers using ArcPy and the new Raster object. I will push an update to this in a few days and you can review that.

There is one outstanding issue that I need to resolve in Raster class and I can push my notebooks up this PR (or I will create a new one)

@DavidJVitale DavidJVitale force-pushed the Esri:master branch from fd14dae to 91c1b41 Jul 10, 2020
@shivanip32
Copy link
Contributor Author

shivanip32 commented Aug 6, 2020

@AtmaMani, could you find time to update the steps for programmatically search and download 5P data using sentinelsat library and to convert netCDF to Raster layers using ArcPy and the new Raster object.

@AtmaMani
Copy link
Member

AtmaMani commented Aug 10, 2020

@shivanip32 I have solved the programmatic download and added a few more enhancements (such as concurrent downloads etc.) I changed the analysis workflow to build out a multivariate multidimensional dataset for two different years and compare the no2 differences. You can find my work in progress notebooks here. I plan to finish this by the end of this sprint if everything works out.

@priyankatuteja
Copy link
Collaborator

priyankatuteja commented Sep 3, 2020

@AtmaMani Awesome! Looking forward to seeing the upcoming sample notebook. Meanwhile, closing this PR as discussed with @shivanip32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.