Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined name: Where is step_remove_ligatures() defined? #317

Open
cclauss opened this issue Jul 2, 2020 · 1 comment
Open

Undefined name: Where is step_remove_ligatures() defined? #317

cclauss opened this issue Jul 2, 2020 · 1 comment

Comments

@cclauss
Copy link

@cclauss cclauss commented Jul 2, 2020

Environment

Cascadia Code version number: GitHub master branch
Application (with version) used to display text:
OS platform and version:
Screen resolution (i.e. 220dpi): 

Any other software?

Steps to reproduce

https://github.com/microsoft/cascadia-code/search?q=step_remove_ligatures

flake8 testing of https://github.com/microsoft/cascadia-code on Python 3.8.3

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./build.py:258:25: F821 undefined name 'step_remove_ligatures'
                        step_remove_ligatures,
                        ^
./build.py:303:17: F821 undefined name 'step_remove_ligatures'
                step_remove_ligatures,
                ^
2     F821 undefined name 'step_remove_ligatures'
2

https://flake8.pycqa.org/en/latest/user/error-codes.html

On the flake8 test selection, this issue does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead these tests are focus on runtime safety and correctness:

  • F82 tests are undefined names which are usually a sign of a typo, missing imports, or code that has not been ported to Python 3. These also would be compile-time errors in a compiled language but in Python a NameError is raised which will halt/crash the script on the user.

Expected behavior

Actual behavior

@aaronbell
Copy link
Collaborator

@aaronbell aaronbell commented Jul 2, 2020

That area of the build script is from an older portion of the code which is currently inactive as we are not building a full Nerd Fonts version of the font (which is why Python doesn't throw any errors). I'll update it to align with the PL build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.