Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUndefined name: Where is step_remove_ligatures() defined? #317
Comments
|
That area of the build script is from an older portion of the code which is currently inactive as we are not building a full Nerd Fonts version of the font (which is why Python doesn't throw any errors). I'll update it to align with the PL build process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Steps to reproduce
https://github.com/microsoft/cascadia-code/search?q=step_remove_ligatures
flake8 testing of https://github.com/microsoft/cascadia-code on Python 3.8.3
$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
https://flake8.pycqa.org/en/latest/user/error-codes.html
On the flake8 test selection, this issue does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead these tests are focus on runtime safety and correctness:
Expected behavior
Actual behavior