github / vscode-codeql Public

Allow multiple analyses for same repo to be downloaded

Remember remote queries across restarts

Add remote query items to history view

Removes the limitation specified in #1089 where analyses for the same
repo and different queries will overwrite each other.

Remote query items will be stored in query history and will remain
available across restarts.

When the extension is restarted, any `InProgress` remote queries will
be monitored until they complete.

When clicked on, a remote query is opened and its results can be
downloaded. The query text and the query file can be opened from the
history menu. A remote query can be deleted as well, which will purge
all results from global storage.

Limitations:

1. Labels are not editable
2. Running multiple queries that each run on the same repository
   will have conflicting results and there will be errors when trying
   to view the results of the second query. This limitation is not new,
   but it is easier to hit now. See #1089.

Both of these limitations will be addressed in future PRs.

Open query server logger for query errors

…y-info

Refactor query history to handle remote and local

Ensure `--addtional-packs` arg not used for empty workspace

Because errors when running queries tend to have better explanations
in the query server log instead of the extension log, by default open
the query server log for query errors.

…/remote-query-save

Store remote query artifacts in global storage

Fix race condition where packs with no name errored during remote query

Avoid re-downloading analyses

This is another incremental step on the way to saving history.

This commit adds remote items to the history view. It adds in progress
and completed icons. Users can explicitly remove items.

Here is what is _not_ working:

1. Any other query history commands like open results or open query.
2. Seeing items after a restart.

Also, rename RemoteQueryInfo -> RemoteQueryHistoryItem

Uses the internal `clear-cache` CLI server command.

…ctor-query-history-info

Avoids re-downloading analyses when downloading all analyses.

This is still an intermediate step as we start to bring in more
abstractions. I plan to implement a storage handler that will
keep track of all the different bits for a remote query.

Store query results for contextual queries elsewhere

This change builds on the previous change to ensure that sarif results
can be displayed properly. Here is what it does:

- Move prepareDownloadDirectory to the RemoteQueryManager
- Store the queryResult to disk
- Use the `artifactStorageDir` as the location where artifacts are kept
- Add `artifactStorageDir` to DownloadLink
- Ensure the webview passes around the right links.

We want them to be deleted when the application exits. We don't want
them to be stored with user queries.

This is a step on the way towards storing remote query history across
restarts.

This PR adds a `QueryHistoryInfo` type that is a union of two types:
`LocalQueryInfo` and `RemoteQueryInfo`.

`LocalQueryInfo` used to be called `FullQueryInfo` and `RemoteQueryInfo`
is only a skeleton right now. The body will be added later. This PR
only introduces it and changes types to make future PRs simpler.

Also, `slurp` and `splat` have been moved to the `query-serialization.ts`
module.